Bump revision for swift-power-assert #1032
Merged
+3
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous revision depended on a version of swift-syntax that had some code that should have never been accepted by the compiler. Bump the revision to a new enough version that has a new enough swift-syntax dependency.
hamishknight
requested review from
justice-adams-apple and
shahmishal
as code owners
hamishknight
commented
Nov 14, 2025
Comment on lines
-3035
to
-3036
| "issue": "Only Supports 5.9+", | ||
| "compatibility": "5.0", |
Collaborator
Author
There was a problem hiding this comment.
I assume this should no longer be needed now the version is correctly set to 5.9
Collaborator
|
@swift-ci test |
This was referenced Nov 14, 2025
Collaborator
|
cc @kishikawakatsumi 👋 Just letting you know we're updating the revision tested in the source compat suite for swift-power-assert so that we can continue to get valid coverage for the project due to some changes in swift-syntax. Nothing for you to do unless you would like to specify a different revision in which case feel free to open a PR |
justice-adams-apple
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous revision depended on a version of swift-syntax that had some code that should have never been accepted by the compiler (see swiftlang/swift#85535 for more info). Bump the revision to a new enough version that has a new enough swift-syntax dependency. I have verified that the new revision builds with Xcode 15.2.